microsoft / times-excel-reader

MIT License
6 stars 2 forks source link

[RFC] Use black formatter? #6

Closed siddharth-krishna closed 1 year ago

siddharth-krishna commented 1 year ago

I propose formatting the codebase using https://pypi.org/project/black/ . It's easy to set up locally to format-on-save, and I can add it to the CI to check pushed commits/PRs. From the doc, benefits of using black:

Black is the uncompromising Python code formatter. By using it, you agree to cede control over minutiae of hand-formatting. In return, Black gives you speed, determinism, and freedom from pycodestyle nagging about formatting. You will save time and mental energy for more important matters.

Blackened code looks the same regardless of the project you're reading. Formatting becomes transparent after a while and you can focus on the content instead.

Black makes code review faster by producing the smallest diffs possible.

Thoughts, @samwebster @tminka @niloyroot ?

samwebster commented 1 year ago

Sounds like a great idea to me. Thanks

niloyroot commented 1 year ago

Just checked it out, this seems very cool!

siddharth-krishna commented 1 year ago

Closed via #8