Remove library name check for __nv_* intrinsics

microsoft / triton-shared

Shared Middle-Layer for Triton Compilation

MIT License

132 stars 26 forks source link

Remove library name check for __nv_* intrinsics #100

Closed aobolensk closed 4 months ago

aobolensk commented 4 months ago

Triton does not set libdevice name for _nv* intrinsics after https://github.com/openai/triton/pull/2887

Remove check for libdevice for _nv* intrinsics
Remove particular NVIDIA-related libdevice name from the tests

nhat-nguyen commented 4 months ago

Thank you! Should we also update the tests to reflect this?

aobolensk commented 4 months ago

Thank you! Should we also update the tests to reflect this?

We have released the limitation here, so library name is not checked, so there is no need to update. But to preserve consistency with what Triton actually emits as of now (could be changed in the future as well), it could be done. WDYT, is it needed?

nhat-nguyen commented 4 months ago

Yea I think let's keep the tests consistent with what triton emits, it will be easier to keep track in the future.

aobolensk commented 4 months ago

Yea I think let's keep the tests consistent with what triton emits, it will be easier to keep track in the future.

OK, I'll update after #98 is merged

aobolensk commented 4 months ago

Done