search

microsoft / triton-shared

Shared Middle-Layer for Triton Compilation
MIT License
163 stars 34 forks source link

Arm64 workflow runner #103

Closed danikhan632 closed 7 months ago

danikhan632 commented 7 months ago

remade the PR here, should work

nhat-nguyen commented 7 months ago

We still have arm-workflow as the target instead of main 😄

danikhan632 commented 7 months ago

We still have arm-workflow as the target instead of main 😄

think I misunderstood, so you want me to merge to main?

nhat-nguyen commented 7 months ago

Yeah I think we misunderstood. My question in the other thread was to confirm if you wanted to merge to main or the arm-workflow branch. If we want to merge to the arm-workflow, I can help with updating the arm-workflow branch so your PR's diffs won't be too overwhelming.

danikhan632 commented 7 months ago

Yeah I think we misunderstood. My question in the other thread was to confirm if you wanted to merge to main or the arm-workflow branch. If we want to merge to the arm-workflow, I can help with updating the arm-workflow branch so your PR's diffs won't be too overwhelming.

I think merging to main might be easier then, I know there are memory issues with 1ES crashing when building triton but we can try main

danikhan632 commented 7 months ago

the upstream binaries are updated, can this be re-run?

aaronsm commented 7 months ago

the upstream binaries are updated, can this be re-run?

Sure. The tests will probably fail because the triple is defaulting to X64. We need OAI to update the LLVM binaries one more time with my last change.

aaronsm commented 7 months ago

@danikhan632 I think the file needs to be formatted

https://github.com/microsoft/triton-shared/actions/runs/8086480662/job/22143942797?pr=103

danikhan632 commented 7 months ago

@danikhan632 I think the file needs to be formatted

https://github.com/microsoft/triton-shared/actions/runs/8086480662/job/22143942797?pr=103

Think it might have been the line spacing