search

microsoft / triton-shared

Shared Middle-Layer for Triton Compilation
MIT License
142 stars 27 forks source link

Add `arith.addi` reduction #20

Closed makslevental closed 9 months ago

makslevental commented 9 months ago

Fixes https://github.com/microsoft/triton-shared/issues/12. Happy to add more tests if you'd like.

makslevental commented 9 months ago

@microsoft-github-policy-service agree

manbearian commented 9 months ago

@makslevental thanks! @nhat-nguyen can you please review

manbearian commented 9 months ago

@makslevental , looks like your new test is failing. Please take a look.

nhat-nguyen commented 9 months ago

Thanks @makslevental for the help! Code changes look good to me. Just need to fix the lit test and we're good to go. :)

nhat-nguyen commented 9 months ago

Thanks @makslevental!