search

microsoft / triton-shared

Shared Middle-Layer for Triton Compilation
MIT License
132 stars 26 forks source link

Fix triton-arith-linalg not using the common patterns #93

Closed nhat-nguyen closed 4 months ago

nhat-nguyen commented 5 months ago

The triton-arith-to-linalg-pass wasn't using the common ConversionPatterns.hpp file, leading to some inconsistencies in the number of patterns populated.

nhat-nguyen commented 5 months ago

@haishanzzzz FYI, I just noticed this because we recently merged a few more patterns in ConversionPatterns.hpp but the new pass didn't pick them up.

haishanzzzz commented 5 months ago

Thank you for the fix @nhat-nguyen! It turned out that I updated our internal code but didn't do that for triton-shared. This two-copy business is madness :D