search

microsoft / ts-fix

CLI for applying TypeScript codefixes
MIT License
111 stars 10 forks source link

Question: Isolated Declarations #32

Closed aminpaks closed 4 months ago

aminpaks commented 4 months ago

Hi folks,

I'm trying to use ts-fix with the TS v5.5 but it's not reporting any errors related to isolatedDeclarations. Would you clarify if ts-fix is working with these errors?

image image
jakebailey commented 4 months ago

See #30

aminpaks commented 4 months ago

@jakebailey is there a trick I don't know, even with the commits from that branch I don't get any fixes! 🤷 

➜  isolated-declaration-test git:(main) ✗ npm run ts-fix -- -t tsconfig.json -f add-annotation --write --ignoreGitStatus

> isolated-declaration-test@1.0.0 ts-fix
> ts-fix -t tsconfig.json -f add-annotation --write --ignoreGitStatus

The project is being created...

Using TypeScript 5.5.0-dev

Found 0 diagnostics in 47 files
No codefixes found with name add-annotation
No changes remaining for ts-fix

No changes made in any files
Done
aminpaks commented 4 months ago

Here is a minimal repo to reproduce the issue.

aminpaks commented 4 months ago

The issue is we need to pass individual tsconfig paths to ts-fix or it wouldn't work. This is confusing, and I believe most folks using composite projects will face this issue.

jakebailey commented 4 months ago

That sounds like a distinct issue to this one, right? As it should affect any and all fixes?