search

microsoft / ts-fix

CLI for applying TypeScript codefixes
MIT License
111 stars 10 forks source link

Incorrect equality comparison/edge case handling for no diagnostics #9

Closed iisaduan closed 2 years ago

iisaduan commented 3 years ago

Original: https://github.com/iisaduan/ts-fix/issues/19

@andrewbranch commented This will never be true since arrays are compared by reference equality. I don’t think the condition is needed, though? https://github.com/iisaduan/ts-fix/blob/90a7e5ce6e25ac064bdc38a0833d9a8731cb11f0/src/index.ts#L70

This line is now https://github.com/microsoft/ts-fix/blob/b3cedc813342bbd77edd56d5ce9fcfae03a9aaa9/src/index.ts#L117