search

microsoft / tsdoc

A doc comment standard for TypeScript
https://tsdoc.org/
MIT License
4.74k stars 131 forks source link

Add tsdoc-characters-after-block-tag in allTsdocMessageIds #212

Closed guillaumewuip closed 4 years ago

guillaumewuip commented 4 years ago

This fixes #211 by adding the missing tsdoc-characters-after-block-tag in allTsdocMessageIds

Fixes https://github.com/microsoft/tsdoc/issues/224

guillaumewuip commented 4 years ago

While this will fix this specific error, this doesn't prevent a new error of the same kind to appear again.

I can help with trying to compute the allTsdocMessageIds variable from the TSDocMessageId enum content of by providing a fallback in case of missing entry in allTsdocMessageIds if one of these options seems good for you :)

octogonz commented 4 years ago

@guillaumewuip Thanks for fixing this! Sorry I overlooked it until now -- something was broken with my email filters for GitHub. :'(

octogonz commented 4 years ago

I can help with trying to compute the allTsdocMessageIds variable from the TSDocMessageId enum content of by providing a fallback in case of missing entry in allTsdocMessageIds if one of these options seems good for you :)

The problem is that TSDocMessageId is a const enum instead of a regular enum. We should probably fix that, but it seems like it might be a breaking API change. (?) Let's tackle it as a separate PR so it doesn't hold up your fix here.

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

octogonz commented 4 years ago

@guillaumewuip Could you sign the CLA?

guillaumewuip commented 4 years ago

Hi @octogonz, I've just signed the CLA ✔️

octogonz commented 4 years ago

This fix was released with tsdoc version 0.12.19 and eslint-plugin-tsdoc version 0.2.4.