search

microsoft / tslib

Runtime library for TypeScript helpers.
BSD Zero Clause License
1.25k stars 126 forks source link

Fix __asyncGenerator to properly handle AsyncGeneratorUnwrapYieldResumption #222

Closed rbuckton closed 11 months ago

rbuckton commented 11 months ago

This applies the same fix from https://github.com/microsoft/TypeScript/pull/56150.

rbuckton commented 11 months ago

Not sure why, but it seems like CodeQL is busted.

jakebailey commented 11 months ago

The workflow is old and needs to be updated; I'll send a PR.

jakebailey commented 11 months ago

https://github.com/microsoft/tslib/pull/223 fixes it.

rbuckton commented 11 months ago

Well, CodeQL isn't erroring, but it isn't doing anything either. Is that expected?

image

jakebailey commented 11 months ago

That is... strange. I'll try and see what's happening. The path I used in the config is correct so I don't know what happened.

jakebailey commented 11 months ago

I think that might be a leftover; the message mentions CodeQL-Build which is the old name of the task before I changed it.

jakebailey commented 11 months ago

Or not... https://github.com/microsoft/tslib/pull/224/checks?check_run_id=17910983224

In any case, this PR looks good to me.