Added new `detect-child-process` rule (#252)

microsoft / tslint-microsoft-contrib

A set of TSLint rules used on some Microsoft projects.

MIT License

702 stars 198 forks source link

Added new `detect-child-process` rule (#252) #855

Closed soon closed 5 years ago

soon commented 5 years ago

PR checklist

[x] Addresses an existing issue: fixes #252
[x] New feature, bugfix, or enhancement
- [x] Includes tests
[x] Documentation update

Overview of change:

Added new detect-child-process rule.

Is there anything you'd like reviewers to focus on?

Spelling (docs), Rule meta (not sure about issueClass, severity and level).

JoshuaKGoldberg commented 5 years ago

Sorry for taking so long to get to this! I'm happy to discuss here or on gitter.im if any of the feedback doesn't make sense!

soon commented 5 years ago

@JoshuaKGoldberg Thanks for your feedback! I've just updated the code, please review

Do we need to handle require(['child_process'])? I've never used this form of require before, but I found some tests including require with array as the first argument for other checks

JoshuaKGoldberg commented 5 years ago

Do we need to handle require(['child_process'])? I've never used this form of require before, but I found some tests including require with array as the first argument for other checks

Ooh, good question. No, let's ignore that for now. Direct AMD modules are falling out of favor and most rules don't bother with them.

soon commented 5 years ago

@JoshuaKGoldberg Anything else should be changed in this PR?

soon commented 5 years ago

@JoshuaKGoldberg Commited your changes