microsoft / tslint-microsoft-contrib

A set of TSLint rules used on some Microsoft projects.
MIT License
702 stars 198 forks source link

Add missing `dir` to the `no-console` #889

Closed astorije closed 4 years ago

astorije commented 5 years ago

PR checklist

Overview of change:

We noticed this was missing, allowing workarounds. I know this repo is in hiatus now, but even if you do not merge, it could be useful for people stumbling over this wondering why this does not trigger. We are actually going to override the rule by removing the list of methods, disallowing all console methods (and that would be my preferred option for the recommended ruleset, even).

I can add tests and docs as needed, if you happen to want to merge this :)

JoshuaKGoldberg commented 4 years ago

Ah, thanks for sending this @astorije! You're right that this PR is good as reference, and also right that since we're moving off of TSLint (#876) we won't be merging this PR. 😦