Make `Object.keys` work on proxies returned by `delay()`

microsoft / tsyringe

Lightweight dependency injection container for JavaScript/TypeScript

MIT License

5.19k stars 172 forks source link

Closed cypherix93 closed 3 years ago

cypherix93 commented 3 years ago

Closes #147

I just made my own fork to test my change and it worked exactly as expected:

I couldn't find any tests for testing this specifically so I didn't add anything. Let me know if you want me to include the tests also.

emilioastarita commented 3 years ago

nice catch! Could be useful if you add one test for the usage of keys

ghost commented 3 years ago

All CLA requirements met.

cypherix93 commented 3 years ago

@emilioastarita Added a test.

emilioastarita commented 3 years ago

LGTM 👍🏼 ! Now we must wait feedback from maintainers