search

microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript
Other
675 stars 118 forks source link

Remove deprecated URL API usage #211

Closed JamieMagee closed 4 years ago

JamieMagee commented 4 years ago

The legacy URL API (provided by require('url')) was deprecated by NodeJS 11 released in October 2018. It is scheduled to be removed in a future release.

The main motivation for this change, is Yarn v2, which does not allow undeclared dependencies to be used. require('url') is ambiguous between the built-in NodeJS module, and the npm package url. I'm assuming the intent is to use the built-in module, so I've migrated to using the new URL API, for which the import is implicit.

stephenmichaelf commented 4 years ago

Closing due to inactivity.