Fix constructor on NO_PROXY with wildcard domain

microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript

Other

675 stars 118 forks source link

Fix constructor on NO_PROXY with wildcard domain #216

Closed tuwrraphael closed 3 years ago

tuwrraphael commented 4 years ago

This fixes #215 by escaping the wildcard for the RegExp. I created the utility function buildProxyBypassRegexFromEnv to allow unit testing of this functionality. A second test ensures the HttpClient constructs with the NO_PROXY environment variable set to a wildcard domain.

msftclas commented 4 years ago

All CLA requirements met.

HonzaMac commented 3 years ago

Can you please take a look on this fix? This break underlying clients when proxy has wildcards "*". cc @mastrzyz @damccorm 🙏

HonzaMac commented 3 years ago

cc @bryanmacfarlane 🙏

damccorm commented 3 years ago

This looks good to me! One last request - would you mind bumping the package.json version? I think this probably merits a patch bump, and I'll merge/release it after that

tuwrraphael commented 3 years ago

done 👍 Thanks for your time & support!

HonzaMac commented 3 years ago

Thank you 🎉🎉🎉🎉

HonzaMac commented 3 years ago

Seems build on main/master branch is failing.

Could you take a look @damccorm ?