search

microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript
Other
675 stars 118 forks source link

Passed timeout to info.options #238

Closed anatolybolshakov closed 4 years ago

anatolybolshakov commented 4 years ago

It seems that timeout is not being passed to request info - fixed it and passed it to request info also.

damccorm commented 4 years ago

Test failures here look unrelated to the change, I think httpbin is having some issues https://github.com/microsoft/typed-rest-client/issues/236

damccorm commented 4 years ago

I'm comfortable merging without tests passing here because of that - @anatolybolshakov I realized you didn't have write permissions, I just added the team so you should have them now

anatolybolshakov commented 4 years ago

I'm comfortable merging without tests passing here because of that - @anatolybolshakov I realized you didn't have write permissions, I just added the team so you should have them now

Ok, thanks! So I'm merging it currently

damccorm commented 4 years ago

Published!