microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript
Other
675 stars 118 forks source link

Only enforce version on build. #45

Closed stephenmichaelf closed 6 years ago

stephenmichaelf commented 6 years ago

We only want to enforce versions on build. When running the tests the node version changes also change the npm version.

I found this while starting to set up builds on VSTS. This is the setup so far (using UI instead of YAML to get it working first ):

image

After Use Node 4.8.6 runs and we start doing npm run test, we were getting this issue:

ERROR: requires npm >= 5.5.1. installed: 2.15.11

I believe this change will resolve the issue since we are just testing and the versions won't be enforced.

I could also see an argument for adding a node only version enforced when testing.