search

microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript
Other
675 stars 118 forks source link

Fix proxy if password has url sensitive characters #50

Closed omeshp closed 6 years ago

omeshp commented 6 years ago

49

TingluoHuang commented 6 years ago

what will happen when my password contains any of these ;,/?:@&=+$, like http://user:pass?word@github.com

omeshp commented 6 years ago

@TingluoHuang tunnel library doesn't send password as a part of URL, it's set in header.

TingluoHuang commented 6 years ago

Looks good to me. thanks for finding and fixing this!

bryanmacfarlane commented 6 years ago

+1 - I can release after you merge