search

microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript
Other
675 stars 118 forks source link

Pass headers to client when passed through constructor #73

Closed stephenmichaelf closed 6 years ago

stephenmichaelf commented 6 years ago

This change fixes a bug where headers passed to the HttpClient constructor don't get passed through.

When passing headers in both the constructor and the method, the method parameter will win.

Resolves #65.

Note that headers passed to the request method is now nullable. Since this is more flexible than the current setup I bumped just the minor.

damccorm commented 6 years ago

Closing since this was resolved by #100. If you think this is a better solution, let me know and we can reopen