search

microsoft / typed-rest-client

Node Rest and Http Clients with typings for use with TypeScript
Other
675 stars 118 forks source link

Support IE11 by targeting es5 #84

Closed damccorm closed 6 years ago

damccorm commented 6 years ago

I think this should allow us to target es5. The only things we use that can't be automatically converted by typescript are Promise and Object.assign, both of which I polyfilled.

Fixes #62

bryanmacfarlane commented 6 years ago

lets talk through before we commit

erwinsmit commented 6 years ago

@bryanmacfarlane Any update on this?

stephenmichaelf commented 6 years ago

@erwinsmit We have not had a chance to discuss this change yet, we will update here when we do! Will try to discuss it in the next day or so.

damccorm commented 6 years ago

We're still discussing this on our end, will try to come to a decision soon. If this is blocking you, I think Babel can help in the meantime - https://babeljs.io/docs/en/

damccorm commented 6 years ago

Ok, after talking this over a little more, I think we're going to hold off on this for now. We may move forward with this in the future, but if we do we want to put forth a more focused effort with more testing/sample support. If this is an issue for you right now, we recommend forking this repo and copying over this pull request.