search

microsoft / types-publisher

This repo has moved:
https://github.com/microsoft/DefinitelyTyped-tools/tree/master/packages/publisher
MIT License
388 stars 151 forks source link

Don't double-prefix version directory name #739

Closed jablko closed 4 years ago

jablko commented 4 years ago

Since this change, pkg.subDirectoryPath returns paths like node/vv10.

orta commented 4 years ago

Cool - this explains https://github.com/DefinitelyTyped/DefinitelyTyped/pull/42377 - /cc @alloy @sandersn

alloy commented 4 years ago

@jablko Was this fix indeed made for the CODEOWNERS file or for failing CI builds such as https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/651445339#L500 ?

alloy commented 4 years ago

I’m going to create another PR that also adds test coverage.

alloy commented 4 years ago

Created https://github.com/microsoft/types-publisher/pull/741.

Alas I wasn’t able to verify if this fixes the CI build failure that I linked to.

sandersn commented 4 years ago

Looks like it did: https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/651445339#L500

alloy commented 4 years ago

@sandersn Can you close this PR, now that #741 has landed?

sandersn commented 4 years ago

Yep, you pulled the fix commit into #741 as I recall.