Open dylang opened 2 years ago
FWIW, the source positions are specifically printed in such a way that smart terminals (like the one in VS Code) can use them as hyperlinks. Since the output is already pretty verbose, that seemed more practical than including source.
Hi @amcasey, thanks for the follow-up.
I agree, the links are helpful, which is why I kept them in the AFTER
above.
However, in the screenshot above there are 16 links. This is one page of perhaps hundreds.
We're not going to click on each link to open the file and to look for patterns that are causing problems.
Showing the source has made it pretty easy for us to scan the code by scrolling through the output.
I tried to make a better POC, but the way the typeTree
data is sometimes an object and sometimes JSON.stringify'ed had me confused and I didn't want to break what you were doing.
Showing the filename and line numbers is helpful, but it means a lot of manually digging when looking for common patterns.
I made another POC. The tree component may need to be fixed or replaced to support new lines.
As a developer using TypeScript, and not somebody developing TypeScript, it might even be more helpful to show less of the internal information, and instead display the results similar to how
tsc
shows errors.BEFORE
AFTER