search

microsoft / typescript-lit-html-plugin

TypeScript server plugin that adds intellisense for lit-html template strings
MIT License
253 stars 20 forks source link

Signature help being showing too often #10

Closed mjbvz closed 6 years ago

mjbvz commented 6 years ago

VS Code 1.24 registered < as a sig help trigger for jsx. This cause us to show signature help whenever you type < inside a html string. This is generally good, except that we end up showing the sig help for the template function itself instead of for the html tags. We should either show the html sig help or nothing when inside html template strings

justinribeiro commented 6 years ago

Debugging it now, it doesn't seem to trigger the getCompletionItems() for that case which is why there aren't any html tags in the completion list. I'll dig it a bit more and see what's cooking.

mjbvz commented 6 years ago

I'm preparing a fix. We will need to override typescript's getSignatureHelpItems function here. This will require an upstream addition to the typescript-template-language-service-decorator library