microsoft / typescript-lit-html-plugin

TypeScript server plugin that adds intellisense for lit-html template strings
MIT License
255 stars 21 forks source link

The selected tag highlight does not work #24

Closed mjbvz closed 5 years ago

mjbvz commented 5 years ago

From @abdonrd on July 7, 2018 1:24

jul-07-2018 01-13-44

Copied from original issue: mjbvz/vscode-lit-html#41

abdonrd commented 5 years ago

@mjbvz I just tried with the last lit-html VSCode extension (v1.8.0), but it doesn't work. 😕

abdonrd commented 5 years ago

@mjbvz could you reopen the issue? Thanks in advance!

mjbvz commented 5 years ago

Works in TS 2.8-3.0. Broken in 3.1+

mjbvz commented 5 years ago

Should have been fixed cde819adbbdbbd5dc1a102b3526f5c6eb1a2ac08. Published as 0.7.1

abdonrd commented 5 years ago

Sorry @mjbvz, I just tried with the v1.9.0 and I have the same behavior:

nov-17-2018 00-46-38

mjbvz commented 5 years ago

You need to be on VS Code 1.30 insiders. 24b0f75b1e33b88f30f2ed9d5b17ca60062c270b or newer

screen shot 2018-11-16 at 3 57 22 pm

abdonrd commented 5 years ago

Oh, yes! It works for me on last insiders! Thanks @mjbvz! 👏