Support for Markdown - Githubissues

microsoft / typescript-lit-html-plugin

TypeScript server plugin that adds intellisense for lit-html template strings

MIT License

255 stars 22 forks source link

Support for Markdown #34

Closed daKmoR closed 4 years ago

daKmoR commented 4 years ago

hey there 👋

it would be awesome if the html highlighting would work for js blocks inside markdown as well. Here is the use case that we are after - Screenshot from VS Code

Screenshot 2020-02-03 at 21 44 06

would be awesome if that is highlighted 👍

any chance we can get some pointers on where to start looking to get this supported? e.g. we can contribute but we probably need a little help to get started 🤗

daKmoR commented 4 years ago

friendly reminder for these questions 🤗

is this something you would consider?
if so how can we help?
any pointers?

mjbvz commented 4 years ago

This repo doesn't actually provide any syntax highlighting; that all lives in the VS Code extension: https://github.com/mjbvz/vscode-lit-html

Can you please move the issue over there. To answer your questions:

Yes, please submit a PR. The fix is to update the injection selectors for the grammar to also target html in markdown files