microsoft / uf2

UF2 file format specification
Other
849 stars 164 forks source link

add ESP32S2 family ID #35

Closed hathach closed 3 years ago

hathach commented 3 years ago

This PR add ESP32S2 family 0xbfdd4eee which is generated randomly with recommended patcher script and currently is used by https://github.com/adafruit/tinyuf2 for esp32s2.

~This also adds bindata_len for carray coversion which is very handy for platform where the actual bootloader size is desired.~

~PS: I am piggy packed 2 features in one PR since the modification is simple enough. Let me know if you want to separate them or want to make any adjustment.~

mmoskal commented 3 years ago

looks good, but please also add the ESP family ID to readme.md

hathach commented 3 years ago

looks good, but please also add the ESP family ID to readme.md

thanks for quick reply, I just realized the ESP32-S2 family ID is already existed in the readme .... hmm, is it used by other project ? I may need to discuss to other Adafruit member for changing the magic number since it is used by circuitpython and maybe other project.

hathach commented 3 years ago

Update: seem like it is added recently by #34 , we should have done this earlier, the ID has been used for like half a year or so. Let me know what should we do in this case

hathach commented 3 years ago

Sorry for spamming: I realize this may take awhile to resolve the family ID conflict, I will just separate the carray len to its own PR #36 since we need this feature for tinyuf2 PR https://github.com/adafruit/tinyuf2/pull/36

mmoskal commented 3 years ago

@hathach as per https://github.com/microsoft/uf2/pull/34#issuecomment-741681843 feel free to update the ids in readme.md (best for all chips supported by tinyuf2 to avoid this problem in future)

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

hathach commented 3 years ago

@hathach as per #34 (comment) feel free to update the ids in readme.md (best for all chips supported by tinyuf2 to avoid this problem in future)

thank you just pushed an update

mmoskal commented 3 years ago

Thanks!