Build improvements - Githubissues

microsoft / v8-jsi

React Native V8 JSI adapter

Other

157 stars 36 forks source link

Build improvements #123

Closed tudorms closed 2 years ago

tudorms commented 2 years ago

Refactor / clean up build scripts (should improve build speed by 5%+)
Add experimental support for building on/for Android, Linux and Mac with the same PowerShell build script

Microsoft Reviewers: Open in CodeFlow

vmoroz commented 2 years ago

Copy-Item "$jsigitpath\public\NapiJsiRuntime.h" -Destination "$OutputPath\build\native\include\"

Should we avoid copying Node-API files if we do not build them?

In reply to: 1104316880

Refers to: scripts/build.ps1:152 in b3ebb5f. [](commit_id = b3ebb5f7077b16698403aad79301ce771d65631e, deletion_comment = False)

ghost commented 2 years ago

Hello @tudorms!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

microsoft / v8-jsi

Build improvements #123

Microsoft Reviewers: Open in CodeFlow

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.