[0.71] Fix Node-API based API shutdown sequence

microsoft / v8-jsi

React Native V8 JSI adapter

Other

157 stars 36 forks source link

Closed vmoroz closed 2 months ago

vmoroz commented 2 months ago

Fixed the shutdown sequence for the Node-API based API.

Rollback all 12.6 related changes in the V8Runtime.
Delete V8RuntimeEnv instance only after all its Node-API environments are destroyed.

Related changes:

Some typo fixes in the README.md
Restore the machine image pool for PR validation (we still must wait till VS 17.11 becomes part of the PR and CI images)

Microsoft Reviewers: Open in CodeFlow

vmoroz commented 2 months ago

It is a copy of PR #208. The hope was that we can bypass building the code. It did not work. Closing this PR.