search

microsoft / v8-jsi

React Native V8 JSI adapter
Other
157 stars 36 forks source link

Fix dll resolution for uwp applications #66

Closed chrisfromwork closed 3 years ago

chrisfromwork commented 3 years ago

Right now the uwp dlls don't get resolved correctly.

  1. The path used always defaults to win32
  2. There is no winmd referenced to include the dlls in the build

To fix this, this review adds the following:

  1. We set the v8platform to uwp if the application is built with the intention of running in an app container
  2. We have the uwp dlls copied to the application output folder so that they get included in the appx
Microsoft Reviewers: Open in CodeFlow
ghost commented 3 years ago

Hello @tudorms!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 52 minutes. No worries though, I will be back when the time is right! :wink:

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.