search

microsoft / v8-jsi

React Native V8 JSI adapter
Other
157 stars 36 forks source link

feat: android pipeline setup #90

Closed shivenmian closed 3 years ago

shivenmian commented 3 years ago

This adds the nuget packaging, local build script and ADO pipeline for v8-jsi Android

Microsoft Reviewers: Open in CodeFlow
JunielKatarn commented 3 years ago

As pointed out by @NikoAri, why is there a need for UNIX-specific shell scripts? Can this project not be built directly on Windows?

tudorms commented 3 years ago

As pointed out by @NikoAri, why is there a need for UNIX-specific shell scripts? Can this project not be built directly on Windows?

I think this is step 2 of the project where we're getting the old version (with V8 7.0) building in the same way to be able to continue servicing.

At step 3 we'll work to unify the code bases across Windows and Android and that's probably the right time to unify the build scripts as well.

FWIW, a very long time ago, the PowerShell scripts were in fact capable of building Android but they were surely broken since then (as I kept making optimizations and only testing on Windows). I suspect reviving that functionality won't be too hard.

shivenmian commented 3 years ago

+1. Adding to what @tudorms said, currently we are using the Android build for react-native-android and other RN Android projects, which are mostly Linux based right now (also see android-pr.yml from rn android). Besides, the script that the Android build uses to install v8 dependencies can only run on Linux.

This PR is to get the pipeline started since there isn't one. Eventually, Android and Windows would run from the same V8 runtime and may have the same build scripts.

shivenmian commented 3 years ago

Android build tested and works on ADO; checking this in.