Protect tcp_server access

microsoft / v8-jsi

React Native V8 JSI adapter

Other

157 stars 36 forks source link

Protect tcp_server access #99

Closed tudorms closed 2 years ago

tudorms commented 2 years ago

If the runtime is quickly created and torn down with inspector enabled we could end up trying to destroy tcp_server before it finishes creating.

This change protects its creation / destruction with a mutex.

Microsoft Reviewers: Open in CodeFlow

ghost commented 2 years ago

Hello @tudorms!

Because this pull request has the auto merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

microsoft / v8-jsi

Protect tcp_server access #99

Microsoft Reviewers: Open in CodeFlow

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.