Open traversaro opened 4 years ago
@traversaro Thanks for posting issue. I reproduced this issue on my vmware. I found:
The powershell remove the directory failed due to file icu-config is a read-only file.
And git bash remove the directory failed due to the directory name has a special symbol.
I try to use powershell and git bash to remove other ports source directory, and I remove successfully. I think the files generated by the building port is based on the source file.
To clarify, i reported the issue because "deleting buildtrees" is document as a way to save space: https://github.com/microsoft/vcpkg/blob/2020.01/docs/about/faq.md#how-can-i-remove-temporary-files .
This is not a VCPKG bug, so I am closing this issue for now.
This is not a VCPKG bug, so I am closing this issue for now.
Hi @LilyWangL , while this is not a vcpkg bug, it affects vcpkg users that follow the vcpkg documentation in https://github.com/microsoft/vcpkg/blob/2020.01/docs/about/faq.md#how-can-i-remove-temporary-files . Perhaps it could make sense to document in the FAQs that using Git Bash or Powershell is not supported to delete the buildtrees?
Perhaps it could make sense to document in the FAQs that using Git Bash or Powershell is not supported to delete the buildtrees?
Upstream issue. The portfile could ensure that the offending files are not left in the buildtrees directory with the read-only attribute flag set but only if this issue cannot be solved by reporting it upstream.
This would appear to be something that needs to be patched out of the source code either upstream or by the port if upstream can't/won't for whatever reason.
It is also a git bash problem which should be reported to the developers.
I don't really understand the calls for support of git bash on Windows when powershell and the command prompt are available. Command prompt has worked in pretty much the same way since DOS through all versions of Windows and basic command scripting should have been taught at schools for a considerable number of years by now. If the Windows alternative to bash was a python shell however..
I don't really understand the calls for support of git bash on Windows when powershell and the command prompt are available. Command prompt has worked in pretty much the same way since DOS through all versions of Windows and basic command scripting should have been taught at schools for a considerable number of years by now.
Hi @heydojo , I am not sure what you refer to as a "calls for support". Git Bash support is explicitly supported by vcpkg (as the boostrap.sh
script works fine), and I think that opening an issue on the vcpkg issue tracker on a specific problem occurring on vcpkg is helpful for vcpkg users, for which the equivalent upstream report may not be as easily found or understandable. If any of the vcpkg maintainer instead feel that these kind of issue are off topic, feel free to close them, thanks!
Describe the bug icu port on Windows creates in its buildtree files with names that cannot be deleted from command line with Powershell or Git Bash
Environment
To Reproduce On Git Bash:
This will fail with the following message:
If you check, it seems that those directories contain a file named
C:
.Deleting the folder is also impossible in powershell (see https://github.com/iit-danieli-joint-lab/idjl-software-dependencies-vcpkg/runs/495928460) while it works fine with cmd prompt (https://github.com/iit-danieli-joint-lab/idjl-software-dependencies-vcpkg/pull/5/checks?check_run_id=496262390).
Expected behavior I expect the delete to work correctly.
Failure logs See https://github.com/iit-danieli-joint-lab/idjl-software-dependencies-vcpkg/runs/495838460 .
Additional context To be honest, I do not know if the problem is in vcpkg's icu port, in icu buildsystem or in Git Bash, but I think it any case it would be good to have an issue to track this if someone faces this problem. Feel free to close if you think it is not directly related to vcpkg.