microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.89k stars 6.32k forks source link

vcpkg autcomplete bash stdout in binary mode #10596

Closed linquize closed 1 year ago

linquize commented 4 years ago

vcpkg autcomplete bash stdout should be in binary mode Output \n instead of \r\n

image

Steps to reproduce: Assume vcpkg is in C:\vcpkg Open Msys2 bash

cd /C/vcpkg
. scripts/vcpkg_completion.bash
./vcpkg install libf<Press tab>
JackBoosY commented 4 years ago

Does this change affect what is displayed when using powershell?

linquize commented 4 years ago

No problem in powershell

JackBoosY commented 4 years ago

Should be fixed.

linquize commented 4 years ago

No, it is not fixed! Trailing ^M still present. Please re-open this issue.

JonLiu1993 commented 1 year ago

@linquiz, sorry for replying to you so late, I followed your steps to reproduce and got different results, can you see where it is different from yours?

 open gitbash
 . scripts/vcpkg_completion.bash
 ./vcpkg install libf  <Press tab>

image

linquize commented 1 year ago

This is because Git Bash from Git for Windows misses some files about bash completion.

https://github.com/git-for-windows/git/issues/2562

LilyWangLL commented 1 year ago

Since this is a issue about Git, so I am closing this issue for now.