JackBoosY
commented
2 years ago All the cmake provided macros are not be declared in hdf5-config.cmake:
- HDF5_FOUND
- HDF5_VERSION
- HDF5_INCLUDE_DIRS
- HDF5_DEFINITIONS
- HDF5_LIBRARIES
- HDF5_HL_LIBRARIES
- HDF5_C_DEFINITIONS
- HDF5_CXX_DEFINITIONS
- HDF5_Fortran_DEFINITIONS
- HDF5_C_INCLUDE_DIRS
- HDF5_CXX_INCLUDE_DIRS
- HDF5_Fortran_INCLUDE_DIRS
- HDF5_C_LIBRARIES
- HDF5_CXX_LIBRARIES
- HDF5_Fortran_LIBRARIES
- HDF5_C_HL_LIBRARIES
- HDF5_CXX_HL_LIBRARIES
- HDF5_Fortran_HL_LIBRARIES
- HDF5_IS_PARALLEL
- HDF5_C_COMPILER_EXECUTABLE
- HDF5_CXX_COMPILER_EXECUTABLE
- HDF5_Fortran_COMPILER_EXECUTABLE
- HDF5_C_COMPILER_EXECUTABLE_NO_INTERROGATE
- HDF5_CXX_COMPILER_EXECUTABLE_NO_INTERROGATE
- HDF5_Fortran_COMPILER_EXECUTABLE_NO_INTERROGATE
- HDF5_DIFF_EXECUTABLE
- HDF5::HDF5
- hdf5::hdf5
- hdf5::hdf5_cpp
- hdf5::hdf5_fortran
- hdf5::hdf5_hl
- hdf5::hdf5_hl_cpp
- hdf5::hdf5_hl_fortran
- hdf5::h5diff
CMake 3.19.x comes with an updated FindHDF5 which now provides targets; @ras0219 / @ras0219-msft indicated as part of the review of https://github.com/microsoft/vcpkg/pull/14716 that we should be providing a drop-in compatible interface with cmake's builtins here.
We should make sure we provide a
vcpkg_cmake_wrapper.cmakewhich provides all of the variables and targets CMake's builtin FindHDF5.cmake provides, and remove several resulting patches in downstream ports.