microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.99k stars 6.35k forks source link

libsass build failure - fails to check for libtool #17657

Open hmoffatt opened 3 years ago

hmoffatt commented 3 years ago

Host Environment

To Reproduce Without system libtool installed: ./vcpkg install libsass

Failure logs

[autoconf-x64-linux-err.log](https://github.com/microsoft/vcpkg/files/6420528/autoconf-x64-linux-err.log)
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
    Command failed: /usr/bin/autoreconf -vfi
    Working Directory: /home/hamish/tmp/vcpkg/vcpkg-2021.04.30/buildtrees/libsass/src/3f75a82396-feba490666.clean/
    Error code: 1
    See logs for more information:
      /home/hamish/tmp/vcpkg/vcpkg-2021.04.30/buildtrees/libsass/autoconf-x64-linux-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_make.cmake:600 (vcpkg_execute_required_process)
  ports/libsass/portfile.cmake:10 (vcpkg_configure_make)
  scripts/ports.cmake:142 (include)

Additional context Problem is solved by installing libtool through the system package manager, but the port fails to check for this.

hmoffatt commented 3 years ago

Also requires but fails to check for automake (for the aclocal) command - discovered this on OSX.

JackBoosY commented 3 years ago

Please provide failure log /home/hamish/tmp/vcpkg/vcpkg-2021.04.30/buildtrees/libsass/autoconf-x64-linux-err.log.

Thanks.

hmoffatt commented 3 years ago

Sorry I thought I had attached it to the original message. autoconf-x64-linux-err.log

JackBoosY commented 3 years ago
src/GNUmakefile.am:27: error: Libtool library used but 'LIBTOOL' is undefined
src/GNUmakefile.am:27:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
src/GNUmakefile.am:27:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.
src/GNUmakefile.am:27:   If 'LT_INIT' is in 'configure.ac', make sure
src/GNUmakefile.am:27:   its definition is in aclocal's search path.

Can you please try install libtool first? sudo apt-get install libtool.

hmoffatt commented 3 years ago

Yes it works if libtool is installed. If autoconf is missing you get a nice error, but not if libtool is missing.

The same problem occurs for automake (if aclocal is missing) on osx.

JackBoosY commented 3 years ago

cc @Neumann-A, we should look for autoconf and libtool in advance in osx/linux I think.

hmoffatt commented 3 years ago

Same problem on Linux (Debian) - that is where I saw the libtool issue.

AYakymov1990 commented 1 year ago

error: building libsass:arm64-osx failed with: BUILD_FAILED Please ensure you're using the latest port files with git pull and vcpkg update. Then check for known issues at: https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+libsass You can submit a new issue at: https://github.com/microsoft/vcpkg/issues/new?title=[libsass]+Build+error&body=Copy+issue+body+from+%2FUsers%2Foleksandrpc%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

jleaders commented 1 year ago

I can confirm this is still an issue on Ubuntu LTS 22.04, and is resolved by sudo apt install libtool -y (autoconf is needed as well)