search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.74k stars 6.29k forks source link

vcpkg's VMSS might no longer need the unencrypted Git protocol #22670

Open StephanTLavavej opened 2 years ago

StephanTLavavej commented 2 years ago

vcpkg's Virtual Machine Scale Set scripts allow the unencrypted Git protocol through the firewall:

https://github.com/microsoft/vcpkg/blob/5fcea86177e7c81fa90e721bba2822649dd4b982/scripts/azure-pipelines/create-vmss-helpers.psm1#L274-L284

GitHub is disabling support for this: https://github.blog/2021-09-01-improving-git-protocol-security-github/

Unless some of vcpkg's ports are manually connecting to other hosting services through this legacy protocol, I suspect that vcpkg can and should remove this firewall exception.

JackBoosY commented 2 years ago

cc @BillyONeal

github-actions[bot] commented 2 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

BillyONeal commented 2 months ago

Still might be used:

@Neumann-A Do you know if https:// would work for these?