Unknown license identifier warning printed twice

[Thomas1664]

Describe the bug A clear and concise description of what the bug is.

Environment

• OS: Windows 10
• Compiler: revision

To Reproduce Steps to reproduce the behavior:

1. Have a port with invalid license expresion, e.g. "BSD-new"
2. Install that port
3. See error

Expected behavior Only print warning once

Failure logs

<manifest>:1:1: warning: Unknown license identifier 'BSD-new'. Known values are listed at https://spdx.org/licenses/
    on expression: BSD-new
                   ^
<manifest>:1:1: warning: Unknown license identifier 'BSD-new'. Known values are listed at https://spdx.org/licenses/
    on expression: BSD-new
                   ^

[JackBoosY]

Confirmed.

[JackBoosY]

The first warning happens on read_manifest, of course, it will print the warning: https://github.com/microsoft/vcpkg-tool/blob/30d6ab6a12b2954becc29f598660c67ec9344cd4/src/vcpkg/commands.format-manifest.cpp#L235

And the second warning happens on open_for_write. When vcpkg write the formated json file, it also will print the warning message: https://github.com/microsoft/vcpkg-tool/blob/30d6ab6a12b2954becc29f598660c67ec9344cd4/src/vcpkg/commands.format-manifest.cpp#L266

cc @BillyONeal

[BillyONeal]

This seems unfortunate but I probably do not have time to fix it. (Contributions welcome!)

[github-actions[bot]]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Thomas1664]

no stale

[github-actions[bot]]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Thomas1664]

No stale

[BillyONeal]

I don't know exactly what fixed this but it looks like it WAS fixed:

PS D:\vcpkg> .\vcpkg.exe version
vcpkg package management program version 2024-07-10-d2dfc73769081bdd9b782d08d27794780b7a99b9

See LICENSE.txt for license information.
PS D:\vcpkg> type D:\vcpkg\ports\zlib\vcpkg.json
{
  "name": "zlib",
  "version": "1.3.1",
  "description": "A compression library",
  "homepage": "https://www.zlib.net/",
  "license": "BSD-new",
  "dependencies": [
    {
      "name": "vcpkg-cmake",
      "host": true
    }
  ]
}
PS D:\vcpkg> .\vcpkg.exe format-manifest D:\vcpkg\ports\zlib\vcpkg.json
D:\vcpkg\ports\zlib\vcpkg.json: warning: $.license (an SPDX license expression): warning: Unknown license identifier 'BSD-new'. Known values are listed at https://spdx.org/licenses/
  on expression: BSD-new
                 ^
Succeeded in formatting the manifest files.
PS D:\vcpkg>

[BillyONeal]

2. Install that port

I see, I misread this; I read @JackBoosY 's note above which was all inside format-manifest and took that as what was going on