[many ports] Dependency on vcpkg-cmake-config but not using vcpkg_cmake_config_fixup

Thomas1664 commented 2 years ago

This seems to be a common copy and paste error. I used a Python script to find out if there are any ports that have a dependence on vcpkg-cmake-config but don't use vcpkg_cmake_config_fixup. The interesting lines are:

if content.find("vcpkg-cmake-config") == -1 or content.find("dependencies") == -1:
          continue
[...]
if content.find("vcpkg_cmake_config_fixup") == -1:
          print(f"- [ ] {entry.name}")

Maybe there is a possibility to add this as a PR suggestion/ manifest format/ post-build check?

[ ] arrayfire
[ ] bext-wintls
[ ] c89stringutils
[ ] clickhouse-cpp
[ ] clipboardxx
[ ] cpp-redis
[ ] cppad
[ ] cppunit
[ ] cspice
[ ] distorm
[ ] easyloggingpp
[ ] eve
[ ] fastor
[ ] graphqlparser
[ ] gsl
[ ] hypodermic
[ ] ijg-libjpeg
[ ] jack2
[ ] jasper
[ ] klein
[ ] kwsys
[ ] laszip
[ ] launch-darkly-server
[ ] libcurl-simple-https
[ ] liblinear
[ ] libopensp
[ ] libressl
[ ] libwebm
[ ] lionkor-commandline
[ ] live555
[ ] lmdb
[ ] lunasvg
[ ] mbedtls
[ ] minio-cpp
[ ] mygui
[ ] nanobench
[ ] opencensus-cpp
[x] openssl
[ ] protobuf
[ ] protozero
[ ] ptyqt
[ ] randomstr
[ ] redis-plus-plus
[ ] rhasheq
[ ] sbp
[ ] skia
[ ] sockpp
[ ] spirv-reflect
[ ] tmxlite
[ ] unicorn-lib
[ ] usockets
[ ] winpty
[ ] wxwidgets
[ ] yasm
[ ] zziplib
[ ] pcre2

Neumann-A commented 2 years ago

qtbase is a false positiv.

dg0yt commented 2 years ago

IMO vcpkg_cmake_config_fixup should be integrated, maybe via a dependency, into vcpkg-cmake. Is there a stand-alone usage?

Thomas1664 commented 2 years ago

IMO vcpkg_cmake_config_fixup should be integrated, maybe via a dependency, into vcpkg-cmake. Is there a stand-alone usage?

Yes, these ports use vcpkg_cmake_config_fixup independently from vcpkg_cmake_*:

gpgme
libgwenhywfar
libsmb2
tomlplusplus

dg0yt commented 2 years ago

I still think that vcpkg_cmake_config_fixup should be integrated into vcpkg-cmake.

github-actions[bot] commented 9 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

Thomas1664 commented 9 months ago

no stale

github-actions[bot] commented 3 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

Thomas1664 commented 3 months ago

no stale

microsoft / vcpkg

[many ports] Dependency on vcpkg-cmake-config but not using vcpkg_cmake_config_fixup #24430