Closed BillyONeal closed 2 years ago
If we don't get someone familiar with these changes upstream I think we should =skip these in ci.baseline.txt
until a maintainer familiar with the situation is available. I'll prepare that if we have no response by the end of this week.
I found the link of Ignition CMake on GitHub is https://github.com/ignitionrobotics/ign-cmake, should we change the upstream of Ignition CMake to this?
Hi @BillyONeal, thanks for pinging me.
https://github.com/orgs/ignitionrobotics/repositories , the upstream for all these ports, reports that it has no repositories.
Individual repos are being redirected to @gazebosim .
We probably shouldn't just "fix the SHA and move on" ... what is the path forward for these libraries in our catalog?
What is happening is that the "Ignition" robotics libraries have been renamed back to "Gazebo" robotics libraries (if you are not familiar with robotics, "Gazebo" is the project from which these libraries were spin off). See https://community.gazebosim.org/t/a-new-era-for-gazebo/1356 for the detailed announcement. This lead all this repositories to be moved from https://github.com/ignitionrobotics/ to https://github.com/gazebosim/, and the repos names have changed from ign-<specificproject>
to gz-<specificproject>
. One of these changes (or the combination of the two, I am not sure) broke the hash of the tarball automatically generated by GitHub (fyi @chapulina in case you encounter this again).
The actual renaming (i.e. change of the metadata contained in the CMake files) will happen from the next major releases of Ignition/Gazebo. As the original tarballs still have the content that they have before the rename, and each Ignition/Gazebo major version of the library is packaged as a separate vcpkg package (as they are side-by-side installable, see https://github.com/microsoft/vcpkg/pull/7781), it probably make sense to just "fix the SHA and move on".
As per https://github.com/microsoft/vcpkg/pull/24618#issuecomment-1121618982 :
This is a good change, but I want to see discussion from the actual Ignition folks about these ports' future. I think the right answer may be to = skip them since they haven't seemed to care about the vcpkg entries for a long time.
I am not a Ignition/Gazebo mantainer, but I was the one that initially packaged Ignition/Gazebo libraries for vcpkg, mainly for supporting Windows. However since when I originally packaged them, I switched most of my packaging effort from vcpkg to conda-forge as conda-forge is more aligned with the use cases of the research group I work in. I never announced this anywhere as I was not aware that vcpkg had any concept of "mantainer" or similar, differently from other package managers. However, probably it could make sense to announce a "call for mantainers" or similar on https://community.gazebosim.org/ . I would be happy to tutor/help anyone in becoming a "mantainer" of this ports (that mainly means updating the vcpkg ports once in a while with new versions) but as I do not use them I do not plan to update them myself in the future.
Pinging other users that could be interested in this discussion: @j-rivero @Ace314159 .
I never announced this anywhere as I was not aware that vcpkg had any concept of "mantainer" or similar, differently from other package managers.
It's not a "formal maintainer" kind of thing. More "people we know will care if this is broken and say something about major upstream changes", sort of thing, since the vcpkg team doesn't actually know how to validate that these things build anything that makes sense.
I never announced this anywhere as I was not aware that vcpkg had any concept of "mantainer" or similar, differently from other package managers.
It's not a "formal maintainer" kind of thing. More "people we know will care if this is broken and say something about major upstream changes", sort of thing, since the vcpkg team doesn't actually know how to validate that these things build anything that makes sense.
Yes, that is completely clear, I was just explaining that it was not clear to me how to specify that in the long term I am not be the best person to be the "people we know will care if this is broken and say something about major upstream changes" .
Hello, @BillyONeal @traversaro: thanks for the ping and the past and present efforts to keep the Ignition (now Gazebo after the last rename) libraries. It would be great if we can keep ignition packages working although the Open Robotics internal resources to help with this effort are limited.
I'm going to ask for help into our public forum so maybe someone from the community can volunteer to help maintaining the libraries here.
I would be able to maintain the libraries here since I am actively using these packages for Gazebo.
I would be able to maintain the libraries here since I am actively using these packages for Gazebo.
Awesome Akash! feel free to ping me anytime if we can help you in with any information or change needed. Thanks!
Thanks a lot @Ace314159 ! Feel free to ping me for any problem.
OK, in light of the above I'm going to ensure https://github.com/microsoft/vcpkg/pull/24618 fixes all of them and run with that. Thanks folks!
/cc
https://github.com/orgs/ignitionrobotics/repositories , the upstream for all these ports, reports that it has no repositories.
Individual repos are being redirected to @gazebosim .
We probably shouldn't just "fix the SHA and move on" ... what is the path forward for these libraries in our catalog?
Related: https://github.com/microsoft/vcpkg/pull/24618