curoky
commented
2 years ago Firstly, cplus_demangle_v3_callback is from demangle.h which is provided by libiberty.
Secondly, folly use __has_include(<demangle.h>) to detect if it has libiberty rather than relying on FOUND_LIBIBERTY which is checked by cmake. For more details, see following code
#if __has_include(<demangle.h>)
static constexpr auto liberty_demangle = cplus_demangle_v3_callback;That means, if you had demangle.h in gcc's default search path, and cmake didn't found libiberty, therefore libiberty.a would't be linked, so you would have that's error message.
As for why cmake can't find libiberty although demangle.h alreay exists. We need check https://github.com/facebook/folly/blob/main/CMake/FindLibiberty.cmake#L15-L29
find_path(LIBIBERTY_INCLUDE_DIR NAMES libiberty.h PATH_SUFFIXES libiberty)
mark_as_advanced(LIBIBERTY_INCLUDE_DIR)
find_library(LIBIBERTY_LIBRARY NAMES iberty)
mark_as_advanced(LIBIBERTY_LIBRARY)
include(FindPackageHandleStandardArgs)
FIND_PACKAGE_HANDLE_STANDARD_ARGS(
LIBIBERTY
REQUIRED_VARS LIBIBERTY_LIBRARY LIBIBERTY_INCLUDE_DIR)
if(LIBIBERTY_FOUND)
set(LIBIBERTY_LIBRARIES ${LIBIBERTY_LIBRARY})
set(LIBIBERTY_INCLUDE_DIRS ${LIBIBERTY_INCLUDE_DIR})
endif()From your logs, libiberty.a is located at /usr/lib64/libiberty.a, I guesse the path /usr/lib64/ is not in find_library's lookup list. The search process of find_library is in https://cmake.org/cmake/help/latest/command/find_library.html.
The easiest way to fix it is deleting demangle.h from your system include path, perhaps /usr/include/demangle.h, If you don't need folly's demangle. Otherwise, you need to give find_library some hints so that it can find libiberty correctly.
dg0yt
uemanon
Host Environment
Linux fedora 5.15.11-200.fc35.x86_64 #1 SMP Wed Dec 22 15:41:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linuxc++ (GCC) 11.3.1 20220421 (Red Hat 11.3.1-2)To Reproduce Steps to reproduce the behavior:
./vcpkg install follyFailure logs vcpkg-tool version: 2022-05-05-67e17c1782801cf481be9ac0b3765dff3e4bdeb8 vcpkg-scripts version: 8e1f46de1 2022-06-10 (3 days ago)
here is part of log at path
.../vcpkg/buildtrees/folly/install-x64-linux-dbg-out.log:Additional context I searched for this and checked the location of the libiberty installation, including the header file
/usr/include/libiberty.hand the static library/usr/lib64/libiberty.a. How can I fix it?