microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.25k stars 6.41k forks source link

Some files in vcpkg repo have wrong permissions #25663

Closed Osyotr closed 2 years ago

Osyotr commented 2 years ago

Describe the bug Some files in vcpkg repo have executable bit set on them: ports/argumentum/portfile.cmake ports/calceph/portfile.cmake ports/calceph/vcpkg.json ports/embree3/fix-path.patch ports/embree3/portfile.cmake ports/embree3/usage ports/freeglut/no_x64_enforcement.patch ports/freeglut/portfile.cmake ports/lz4/0001-Fix-potential-memory-corruption-with-negative-memmov.patch ports/mbedtls/enable-pthread.patch scripts/cmake/vcpkg_build_nmake.cmake versions/s-/spdlog.json

Expected behavior These files should have 644 permissions instead of 755.

Cheney-W commented 2 years ago

Below are the file permissions in my side, It looks neither 644, nor 755:

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/argumentum/portfile.cmake
-rwxrwxr-x 1 vxincwa vxincwa 763 Jun 30 08:57 ports/argumentum/portfile.cmake

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/calceph/portfile.cmake
-rwxrwxr-x 1 vxincwa vxincwa 2048 Jun 30 08:57 ports/calceph/portfile.cmake

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/calceph/vcpkg.json
-rwxrwxr-x 1 vxincwa vxincwa 356 Jun 30 08:57 ports/calceph/vcpkg.json

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/embree3/fix-path.patch
-rwxrwxr-x 1 vxincwa vxincwa 3761 Jun 30 08:57 ports/embree3/fix-path.patch

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/embree3/portfile.cmake
-rwxrwxr-x 1 vxincwa vxincwa 2764 Jun 30 08:57 ports/embree3/portfile.cmake

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/embree3/usage
-rwxrwxr-x 1 vxincwa vxincwa 139 Jun 30 08:57 ports/embree3/usage

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/freeglut/no_x64_enforcement.patch
-rwxrwxr-x 1 vxincwa vxincwa 672 Jun 30 08:57 ports/freeglut/no_x64_enforcement.patch

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/freeglut/portfile.cmake
-rwxrwxr-x 1 vxincwa vxincwa 2122 Jun 30 08:57 ports/freeglut/portfile.cmake

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/lz4/0001-Fix-potential-memory-corruption-with-negative-memmov.patch
-rwxrwxr-x 1 vxincwa vxincwa 757 Jun 30 08:57 ports/lz4/0001-Fix-potential-memory-corruption-with-negative-memmov.patch

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l ports/mbedtls/enable-pthread.patch
-rwxrwxr-x 1 vxincwa vxincwa 2851 Jun 30 08:57 ports/mbedtls/enable-pthread.patch

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l scripts/cmake/vcpkg_build_nmake.cmake
-rwxrwxr-x 1 vxincwa vxincwa 5332 Jun 30 08:57 scripts/cmake/vcpkg_build_nmake.cmake

vxincwa@vxincwa-wcpp-5:~/vcpkg$ ls -l versions/s-/spdlog.json
-rwxrwxr-x 1 vxincwa vxincwa 4273 Jun 30 08:57 versions/s-/spdlog.json
Osyotr commented 2 years ago

-rwxrwxr-x

@Cheney-W as you can see, they all have executable bit which is wrong.

Cheney-W commented 2 years ago

Does this issue affect the operation of vcpkg? If not, I will close this issue as won't fix.

Osyotr commented 2 years ago

No, I don't think so. They might show up when interacting with vcpkg repo that resides in WSL.