microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.4k stars 6.47k forks source link

Should ISPC be a well-known tool? #26965

Closed Tradias closed 1 year ago

Tradias commented 2 years ago

I am planning on contributing the port files of OSPRay, OpenVLK and rkcommon that I have created. They depend on ISPC. I currently use find_program in their port files to acquire the system installed variant of it, but that will certainly not work for the vcpkg pipelines here. Therefore my question, how to best handle it? Adding it to vcpkg_find_acquire_program sounds like an option, but since ISPC is a compiler, I am not sure that is the right place (seeing that compilers are generally expected to be provided through toolchain files).

See also previous issues on ISPC: https://github.com/microsoft/vcpkg/issues/15846, https://github.com/microsoft/vcpkg/issues/8698

LilyWangLL commented 2 years ago

Thanks for posting this issue, you can add it like vcpkg-tool-meson or vcpkg-tool-gn.

JonLiu1993 commented 1 year ago

Fixing by PR #29261

github-actions[bot] commented 1 year ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] commented 1 year ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] commented 1 year ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.