search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.83k stars 6.3k forks source link

[vcpkg] Let it fails when uploading binary caching failed #28927

Open xiaozhuai opened 1 year ago

xiaozhuai commented 1 year ago 
error: curl failed to put file to https://xxx.com/packages/x64-osx-dynamic/zlib/1.2.13/23bb6610a3e542385afd48ad46945d93065459e7a691911c8ee88183779fc221.zip with exit code 6 and http code 0.

I config a http binary caching backend for my vcpkg, and is the only one, which is read-write.

I'd like to let it fails when uploading failed.

autoantwort commented 1 year ago

Maybe we should add a flag like --require-binary-cache-upload or --binarycache-hard-errors

autoantwort commented 1 year ago

If you get an error like error: curl failed to execute with exit code 6. while uploading to the binary cache you already get a full stop, which is inconsistent.

xiaozhuai commented 1 year ago

Maybe we should add a flag like --require-binary-cache-upload or --binarycache-hard-errors

Maybe we should also add an env variable to control this. Then we can make it as the default behavior through env.

autoantwort commented 1 year ago

If you get an error like error: curl failed to execute with exit code 6. while uploading to the binary cache you already get a full stop, which is inconsistent.

Btw if anyone else gets this error randomly: I got rate limited by my pihole... Increasing the rate limit for DNS requests solved this problem.

xiaozhuai commented 1 year ago

Maybe we need to retry a few more times if uploading failed.

xiaozhuai commented 1 year ago

Time flies, any plan on this issue?

ameya-deshmukh commented 1 year ago

@xiaozhuai hey! I've been using vcpkg extensively for a project of mine and would like to take this up to give back to the community. Can I work on this?

xiaozhuai commented 1 year ago

@ameya-deshmukh Of course, you can fork vcpkg-tool and open a PR. : )

github-actions[bot] commented 8 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

autoantwort commented 8 months ago

still a thing

github-actions[bot] commented 1 month ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

autoantwort commented 1 month ago

still a thing