search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.13k stars 6.37k forks source link

[openh264] (fixed upstream) openh264.pc references -lstdc++ on Windows, breaking gstreamer #32586

Open comex opened 1 year ago

comex commented 1 year ago

Describe the bug When building openh264 natively on Windows, the generated pkg-config file has a reference to -lstdc++, which isn't used on native Windows targets.

This appears to be fixed upstream already: if I add HEAD_REF master to portfile.cmake and build with --head, the pkg-config file is correct. The fix was probably this PR merged in 2022.

Environment

To Reproduce Steps to reproduce the behavior:

  1. ./vcpkg install openh264:x64-windows-static
  2. Look at packages/openh264_x64-windows-static/lib/pkgconfig/openh264.pc and note that it includes: 
    Libs.private: -lstdc++
  3. Run ./vcpkg install gstreamer[openh264]:x64-windows-static and it will fail with: 
    LINK : fatal error LNK1181: cannot open input file 'stdc++.lib'

If you build for x64-windows instead of x64-windows-static, the pkg-config file is still incorrect, but it doesn't break gstreamer since Libs.private isn't used for dynamic linking.

FrankXie05 commented 1 year ago

PR https://github.com/cisco/openh264/pull/3247 for c++ porting.

github-actions[bot] commented 9 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] commented 3 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

FrankXie05 commented 3 months ago

No stale.

dg0yt commented 3 months ago

Blocked by #32590.