search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.9k stars 6.32k forks source link

[azure-kinect-sensor-sdk] Build error #33137

Closed thundercarrot closed 2 weeks ago

thundercarrot commented 1 year ago

Package: azure-kinect-sensor-sdk[core,tool]:x64-windows -> 1.4.1#5

Building with "tool" feature fails. ImGui's SetNextTreeNodeOpen was previously deprecated and now has been removed. Call SetNextItemOpen instead.

see https://github.com/ocornut/imgui/blob/1362fc0c56d8742167379661a353d8342f7c4a86/imgui.h#L3131

As an aside, I was on the way to creating a patch and PR for it, but without --editable support in manifest mode, this seems pretty onerous. Is there a recommended way to do this?

Host Environment

To Reproduce

vcpkg install

Failure logs

buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4adevicedockcontrol.cpp(336): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui' buildtrees\azure-kinect-sensor-sdk\src\v1.4.1-4fd9fcd081.clean\tools\k4aviewer\k4asourceselectiondockcontrol.cpp(37): error C2039: 'SetNextTreeNodeOpen': is not a member of 'ImGui'

Adela0814 commented 1 year ago

Confirmed, I can repro this in my side.

github-actions[bot] commented 6 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

github-actions[bot] commented 2 weeks ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

jimwang118 commented 2 weeks ago

This issue has been fixed by PR 40812.