search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.92k stars 6.33k forks source link

[getopt-win32] should use official repo #34158

Closed jiayuehua closed 12 months ago

jiayuehua commented 1 year ago

Is your feature request related to a problem? Please describe.

https://github.com/microsoft/vcpkg/blob/c6d6efed3e9b4242765bfe1b5c5befffd85f7b92/ports/getopt-win32/portfile.cmake#L3 now the getopt-win32 not using offcial repo https://github.com/libimobiledevice-win32/getopt"

Proposed solution

should using official repo. any change should use patch or summit pr to upstream.

Describe alternatives you've considered

No response

Additional context

No response

dg0yt commented 1 year ago

Why do you think libimobiledevice-win32/getopt is the official repo? Are you aware of the problems with the past state of those libimobiledevice(-win32) ports?

dg0yt commented 1 year ago

In particular, read https://github.com/microsoft/vcpkg/pull/33246#issuecomment-1710785895 and following.

JonLiu1993 commented 12 months ago

@jiayuehua, Thanks for posting this issue, I think @xiaozhuai has explained your question in comment, so I will close this issue.