[osg] incorrect plugins install path

[Pospelove]

Host: arm64-windows Target: x64-windows Steps to reproduce:

vcpkg install osg:x64-windows
cmake --build ... // building my project

Expected result:

• No installed/plugins/osgPlugins-3.6.5 folder
• Should create ${CMAKE_BINARY_DIR}/Release/osgPlugins-3.6.5 folder during CMake --build

Real result:

• Creating installed/plugins/osgPlugins-3.6.5 folder
• No ${CMAKE_BINARY_DIR}/Release/osgPlugins-3.6.5 folder during CMake --build

Screenshot:

[Pospelove]

${CMAKE_BINARY_DIR}/${cfg}/osgPlugins-3.6.5 should be created because OSG-based apps require that path to contain DLLs

At least OpenMW needs that

[dg0yt]

*/Release/* looks like a specific MSVC build-time pattern and shouldn't be hard-coded. Perhaps you can tell OpenMW where they are actually located? This is information which the osg CMake config already provides IIRC.

[Pospelove]

*/Release/* looks like a specific MSVC pattern and shouldn't be hard-coded. Perhaps you can tell OpenMW where they are actually located? This is information which the osg CMake config already provides IIRC.

those plugins are just shared libraries. I guess they should go to bin folder and they also should be copied into cmake binary dir while building a user project

[dg0yt]

Plugins are shared libraires, or DLLs, by nature. However, they are not meant to be linked directly, and they don't come with import libs on windows. That's why they are treated differently.

[Pospelove]

Plugins are shared libraires, or DLLs, by nature. However, they are not meant to be linked directly, and they don't come with import libs on windows. That's why they are treated differently.

I see. Do you confirm that installed/plugins is the correct place and will be kept the same?

or should/will they go to tools, share, etc

[dg0yt]

Do you confirm that installed/plugins is the correct place and will be kept the same?

AFAICT <prefix> plugins is the general place to collect plugins/modules. The implementation in port osg is intentional, based on past discussions, and I'm not aware of intentions to change it.

There is a documentation PR for the installation directory layout: https://github.com/microsoft/vcpkg-docs/pull/162 Disclaimer: The plugin mention was added on my request, and I'm only a contributor.

or should/will they go to tools, share, etc

For convenience, the port does deploy them to tools, too.

NB: There is a tradeoff between following upstream patterns closely and providing a fairly consistent behaviour across ports and platforms. And there is still a gap in vcpkg supporting deployment of plugins to consuming projects.

[Pospelove]

Thank you for your explanation! I'll consider closing this issue or rewriting it.

I wish to have plugins installed in the right way, but not sure if vcpkg has anything to do with that

[github-actions[bot]]

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

[Pospelove]

ааа

[dg0yt]

ааа

???