microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.41k stars 6.47k forks source link

[ANGLE] update to Chromium 6057 #34380

Open TrajansRow opened 1 year ago

TrajansRow commented 1 year ago

Library name

ANGLE

New version number

Chromium 6057

Other information that may be useful (release notes, etc...)

There is now support for OpenGL ES 3.0 with the Metal backend in ANGLE, which has been added since the last port update.

mattleibow commented 10 months ago

Might be worth updating to chromium/6274 since that will have my changes for UWP (reduce a patch in this repo) and WinUI (I will add a new PR for this). I had a try but then I see they changed the code in the .gni files so the gni-to-cmake script is doing weird things.

gni

libangle_common_sources = libangle_common_headers + [
  "src/common/Float16ToFloat32.cpp",
    ...

cmake

set(libangle_common_sourceslibangle_common_headers + [
    "src/common/Float16ToFloat32.cpp"
    ...

and then the build fails. If we want a perfect world, we can fix webkit? But maybe it is better to just copy the script into the portfile so we can do this and then upstream the fixes? Not sure if webkit actually hits this so it does not matter so much to them.

mattleibow commented 10 months ago

Or maybe this is a better option: https://github.com/microsoft/vcpkg/issues/11617

TrajansRow commented 10 months ago

Really, this request should be more like "Update to the latest chromium". For the title, I just picked the version that was current in October.

github-actions[bot] commented 4 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

abram commented 3 months ago

Adding a comment to (hopefully) re-open. A more up to date ANGLE port would be very useful. Thanks to all who have and will work to make this possible!

hsdk123 commented 3 months ago

Requesting help here as well for ios: https://github.com/microsoft/vcpkg/issues/40634