search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.43k stars 6.2k forks source link

[New Port Request] embree4 #35683

Closed swolter1701 closed 2 months ago

swolter1701 commented 7 months ago

Library name

Embree4

Library description

high-performance ray tracing library

Source repository URL

https://github.com/embree/embree/releases/tag/v4.3.0

Project homepage (if different from the source repository)

https://www.embree.org/

Anything else that is useful to know when adding (such as optional features the library may have that should be included)

older version of embree v3.x is already in vcpkg: embree3 | Version: 3.13.5

theblackunknown commented 6 months ago

I am interested to tackle this in the future, however should we create yet another port or simply stop putting the version into the port name and just use the manifest version field ?

In a nutshell, I am proposing to deprecate the embree3 port - or making it a stub port - and create the embree port instead of embree4

githubkusi commented 6 months ago

please keep embree3 and create a new port for embree4. There are still many libraries which depend on embree3. Currently, it is cumbersome to install a specific version of a library from the command line. I believe proper versioning is only available in manifest mode

Having said that, thanks a lot for working on embree4, much appreciated!

theblackunknown commented 6 months ago

Indeed, I am used to manifest mode only those days but I understand this can be painful when it is not used at all and have to force people into doing custom overlay ports...

That said, and assuming we will have a embree4 port. Would it be useful to have a embree meta port which simply point to the latest desired version (and which can also be either versioned and/or overlaid) ?

dg0yt commented 6 months ago

Such meta ports come with own maintenance issues: they have to mirror the actual port's features. Example: opencv vs. opencv4.

Having two ports can cause problems if they provide the same files (cf. opencv ports) or symbols (may break msbuild autolinking). It is possible to exclude the older version from vcpkg CI if the they provide the same files (cf. opencv3). But then it may break silently.

github-actions[bot] commented 4 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

zhai-xiao commented 4 months ago

I'm also waiting for embree4. Thank you!

github-actions[bot] commented 2 months ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 60 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.