search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.74k stars 6.29k forks source link

[tracy] support for disabled tracy #36725

Open qbojj opened 6 months ago

qbojj commented 6 months ago

Is your feature request related to a problem? Please describe.

Tracy has a TRACY_ENABLE flag that makes all its functions NO-OPS (empty defines). What it means, that users of the library can use the same source without additional ifdefs for release for end users and internal performance testing.

It would be helpful if vcpkg had a "null" port of tracy for use in final releases.

Proposed solution

Add a (possibly default) feature that sets TRACY_ENABLE to ON (otherwise OFF)

Describe alternatives you've considered

No response

Additional context

No response

jimwang118 commented 6 months ago

TRACY_ENABLE: ON has been set in the cmakelists.txt file of the upstream code, and no additional settings are required.

dg0yt commented 6 months ago

Couldn't a default feature profiling solve the issue?

TRACY_ENABLE: ON has been set in the cmakelists.txt file of the upstream code, and no additional settings are required.

Misses the point.

github-actions[bot] commented 1 week ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.