microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.35k stars 6.45k forks source link

[proxygen] build failure #38086

Closed jkammerland closed 1 month ago

jkammerland commented 7 months ago

Operating system

Linux

Compiler

GCC 13.2

Steps to reproduce the behavior

vcpkg install proxygen

Failure logs

undefined reference to `io_uring_submit'

i.e /usr/bin/ld: /home/jonkam/Programmering/cpp/cpp_rebuild_template/build/vcpkg_installed/x64-linux/debug/lib/libfolly.a(IoUringBackend.cpp.o): in function folly::IoUringBackend::submitBusyCheck(int, folly::IoUringBackend::WaitForEventsMode)': /home/jonkam/Programmering/cpp/cpp_rebuild_template/vcpkg/buildtrees/folly/src/4.01.01.00-60a2322077.clean/folly/experimental/io/IoUringBackend.cpp:1874: undefined reference toio_uring_submit'

Additional context

Not a selfcontained package. Fedora 38 got liburing-devel installed.

dg0yt commented 7 months ago

Upstream folly and proxygen don't allow control over liburing, but rely on __has_include. To resolve installation order issues, the ports need additional patches, or must unconditionally depend on and use uring on linux.

(Fixing the uring feature in folly is not enough.)

github-actions[bot] commented 1 month ago

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.